Fix segfault for large bases in perlin noise #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomnes
reviewed
Feb 17, 2022
| ii = ((ii + base) & 255); | ||
| jj = ((jj + base) & 255); | ||
| kk = ((kk + base) & 255); | ||
|
|
There was a problem hiding this comment.
From what I understand you're capping the result to 255. This can be misleading to the user since it's a hidden operation : the user could expect different results with larger values for base and not get them.
I'd recommend throwing an error or at least a warning.
Author
|
I think you're right, this commit throws errors for bases that have the potential to be non-unique. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code segfaults for large bases because it reads past the end of the _PERM array. There are a few possible fixes with advantages and disadvantages. This fix accepts all bases, but it cycles with a period of 256. An alternative method is to throw an error for bases larger than 256.