Implement BuildLayoutParameters so hermit Gradle is used by all IDE execution paths#113
Merged
jvmakine merged 1 commit intocashapp:mainfrom Mar 2, 2026
Merged
Conversation
joshfriend
force-pushed
the
jfriend/fix-java-issues
branch
from
e790f25 to
b36a398
Compare
autonomousapps
approved these changes
Feb 5, 2026
joshfriend
force-pushed
the
jfriend/fix-java-issues
branch
from
245def7 to
b36a398
Compare
wsutina
approved these changes
Feb 6, 2026
wsutina
reviewed
Feb 6, 2026
| log.debug("waiting for 'hermit install' to be finished before continuing with Gradle preparation") | ||
|
|
||
| val start = System.currentTimeMillis() | ||
| val deadlineNanos = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(TIMEOUT_MS) |
Contributor
There was a problem hiding this comment.
Why does this need to be changed?
Collaborator
Author
There was a problem hiding this comment.
It doesn't have to, I just thought I would clean it up while I was here to use a monotonic clock source. Can split this into a separate PR though.
…xecution paths GradleExecutionHelper and high-level APIs like ExternalSystemUtil.runTask resolve the Gradle distribution via GradleExecutionAware.getBuildLayoutParameters, which previously returned null from this plugin, causing the IDE to fall back to its bundled Gradle when no wrapper properties file exists. Also adds a path-existence guard in HermitJdkUpdater to surface a user-facing error instead of crashing when the JDK home doesn't exist on disk.
ss-block
approved these changes
Feb 6, 2026
joshfriend
force-pushed
the
jfriend/fix-java-issues
branch
from
b36a398 to
29e991c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GradleExecutionHelperand high-level APIs likeExternalSystemUtil.runTaskresolve the Gradle distribution viaGradleExecutionAware.getBuildLayoutParameters, which previously returned null from this plugin, causing the IDE to fall back to its bundled Gradle when no wrapper properties file exists. Also adds a path-existence guard inHermitJdkUpdaterto surface a user-facing error instead of crashing when the JDK home doesn't exist on disk.