Make platform blocks explicit for opa and yajsv#748
Open
Renjuju wants to merge 1 commit intocashapp:masterfrom
Open
Make platform blocks explicit for opa and yajsv#748Renjuju wants to merge 1 commit intocashapp:masterfrom
Renjuju wants to merge 1 commit intocashapp:masterfrom
Conversation
opa.hcl: Change `linux {}` and `darwin {}` to `platform "linux" "amd64" {}`
and `platform "darwin" "amd64" {}` in the v0.30.1 block so hermit doesn't
try to install amd64 binaries on arm64 machines. Newer versions already
use `${arch}` and support arm64 natively.
yajsv.hcl: Replace top-level source (which matched all platforms
including arm64) with explicit `platform "linux" "amd64" {}` block since
no linux-arm64 binary exists. Darwin keeps the arch-unqualified block
(works via Rosetta on arm64 macs).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Eric Tam <erict@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux {}anddarwin {}toplatform "linux" "amd64" {}andplatform "darwin" "amd64" {}in the v0.30.1 block so hermit doesn't try to install amd64 binaries on arm64 machines. Newer versions (0.38.1+) already use${arch}and support arm64 natively.platform "linux" "amd64" {}block since no linux-arm64 binary exists. Darwin keeps the arch-unqualified block (works via Rosetta on arm64 macs).Same pattern as #747 (codecov).