Skip to content

Fix image diff to properly handle different image sizes #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rqcai wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix image diff to properly handle different image sizes #2889

rqcai wants to merge 2 commits into from

Conversation

@rqcai
Copy link
Collaborator

@rqcai rqcai commented Oct 31, 2025

Previously had swapped loop bounds (y used minWidth, x used minHeight) and
only compared overlapping region, causing incomplete diff visualization.

@JakeWharton
Copy link
Collaborator

JakeWharton commented Nov 1, 2025

Weird failure. I'll look into it Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rqcai @JakeWharton