Add support for DKK, SEK, and NOK currencies#201
Merged
a1denvalu3 merged 4 commits intomainfrom Mar 3, 2026
Merged
Conversation
Adds Danish Krone, Swedish Krona, and Norwegian Krone to supported currencies. Updates Amount parsing to handle multi-character symbols and ambiguous currency codes (kr). Updates UI to allow selecting new currencies.
a1denvalu3
force-pushed
the
feat/add-nordic-currencies
branch
from
82de26d to
48eb5c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Danish Krone (DKK), Swedish Krona (SEK), and Norwegian Krone (NOK) to the Numo app.
Changes
Amount.Currencyenum to includeDKK,SEK, andNOK.Amount.parseto handle multi-character symbols and ambiguous symbols (e.g., "kr") by prioritizing the user's selected currency.CurrencyManagerto provide correct symbols ("kr.", "kr") and Coinbase API URLs.BitcoinPriceWorkerto fetch and cache prices for the new currencies.CurrencySettingsActivityand UI to include radio buttons for selecting these currencies.Amountparsing and formatting with the new currencies.Testing
Amount.parsecorrectly handles "kr." (DKK) and "kr" (SEK/NOK).CurrencyManagerreturns correct symbols and API URLs.