Skip to content

fix: resolve issues 196, 197, 198#202

Merged
a1denvalu3 merged 1 commit intomainfrom
fix-issues-196-197-198
Mar 6, 2026
Merged

fix: resolve issues 196, 197, 198#202
a1denvalu3 merged 1 commit intomainfrom
fix-issues-196-197-198

Conversation

@a1denvalu3
Copy link
Collaborator

Summary

This PR addresses three distinct UI and logic issues:

  • Fixes Button Text Doesnt Change on Theme Change #196: Replaced hardcoded @android:color/white on dialog buttons with theme-aware @color/color_bg_white so they invert correctly when the background switches to white in dark mode. Also fixed the background on the item variation add button to invert properly.
  • Fixes Text Cutoff on "Add Item" Screen #197: Fixed text truncation on the "Add Item" screen by modifying the fixed 100dp layout widths on form labels to wrap_content with a minWidth. This ensures longer localized strings and different font scales don't get arbitrarily cut off.
  • Fixes Incorrect Error and Disallowance of Price #198: Updated PricingHandler regex to allow user prices to start with a decimal separator (e.g. .55).

Resolves #196 - Fixes button text colors staying white in dialogs on dark theme

Resolves #197 - Fixes text cutoffs on Add Item screen by making layout widths dynamic

Resolves #198 - Allows starting price input with decimal points (e.g. .55)
@github-project-automation github-project-automation bot moved this to Backlog in Numo Mar 4, 2026
@a1denvalu3 a1denvalu3 merged commit 290a292 into main Mar 6, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Numo Mar 6, 2026
@a1denvalu3 a1denvalu3 deleted the fix-issues-196-197-198 branch March 6, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Incorrect Error and Disallowance of Price Text Cutoff on "Add Item" Screen Button Text Doesnt Change on Theme Change

1 participant