Open
Conversation
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
- Coverage 55.36% 52.50% -2.86%
==========================================
Files 84 84
Lines 9479 9652 +173
==========================================
- Hits 5248 5068 -180
- Misses 4231 4584 +353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
There is a problem here: when paying, backends cannot distinguish whether the amount on the quote is a partial amount or the full amount for a amountless invoice. |
…xception as well.
5dd2f1a to
4790876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Objective
Adds support for amountless payment requests (e.g. bolt11 amountless invoices)
and signals support in the info endpoint (mint features)
cashubtc/nuts#173
Enabled for:
Also Added
PaymentQuoteKind:REGULARfor regular quotesAMOUNTLESSfor quotes where the amount is specified in the amountless optionPARTIALfor quotes where we pay only the partial amount specified in the mpp optionm07_add_payment_quote_kindmigration adds thekindcolumn tomelt_quotesin the DB. Defaults toREGULARfor all already present records.