Skip to content

[FEAT] Amountless Melt Requests#712

Open
a1denvalu3 wants to merge 74 commits intocashubtc:mainfrom
a1denvalu3:amountless-invoices
Open

[FEAT] Amountless Melt Requests#712
a1denvalu3 wants to merge 74 commits intocashubtc:mainfrom
a1denvalu3:amountless-invoices

Conversation

@a1denvalu3
Copy link
Collaborator

@a1denvalu3 a1denvalu3 commented Feb 25, 2025

Main Objective

Adds support for amountless payment requests (e.g. bolt11 amountless invoices)
and signals support in the info endpoint (mint features)

cashubtc/nuts#173

Enabled for:

  • CLN
  • LND
  • Fake
  • Blink
  • LNbits
  • Strike

Also Added

PaymentQuoteKind:

  • REGULAR for regular quotes
  • AMOUNTLESS for quotes where the amount is specified in the amountless option
  • PARTIAL for quotes where we pay only the partial amount specified in the mpp option

m07_add_payment_quote_kind migration adds the kind column to melt_quotes in the DB. Defaults to REGULAR for all already present records.

@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 27.17949% with 142 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (3e32dc4) to head (5e4aac8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cashu/lightning/clnrest.py 7.89% 35 Missing ⚠️
cashu/lightning/lnd_grpc/lnd_grpc.py 8.57% 32 Missing ⚠️
cashu/lightning/lndrest.py 8.57% 32 Missing ⚠️
cashu/lightning/fake.py 15.00% 17 Missing ⚠️
cashu/core/mint_info.py 18.18% 9 Missing ⚠️
cashu/wallet/wallet.py 25.00% 6 Missing ⚠️
cashu/wallet/v1_api.py 25.00% 3 Missing ⚠️
cashu/core/errors.py 81.81% 2 Missing ⚠️
cashu/mint/ledger.py 50.00% 2 Missing ⚠️
cashu/core/models.py 90.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   55.36%   52.50%   -2.86%     
==========================================
  Files          84       84              
  Lines        9479     9652     +173     
==========================================
- Hits         5248     5068     -180     
- Misses       4231     4584     +353     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1denvalu3 a1denvalu3 marked this pull request as draft February 27, 2025 17:26
@a1denvalu3
Copy link
Collaborator Author

a1denvalu3 commented Mar 5, 2025

There is a problem here: when paying, backends cannot distinguish whether the amount on the quote is a partial amount or the full amount for a amountless invoice.

@a1denvalu3 a1denvalu3 added the ready Reviewed, tested, ready to merge label Jun 4, 2025
@a1denvalu3 a1denvalu3 changed the title Amountless Melt Requests [FEAT] Amountless Melt Requests Jun 4, 2025
@a1denvalu3 a1denvalu3 force-pushed the amountless-invoices branch 4 times, most recently from 5dd2f1a to 4790876 Compare June 4, 2025 16:20
@ye0man ye0man added this to nutshell Jan 21, 2026
@github-project-automation github-project-automation bot moved this to Backlog in nutshell Jan 21, 2026
@a1denvalu3 a1denvalu3 moved this from Backlog to Needs Review in nutshell Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Reviewed, tested, ready to merge

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

2 participants