Open
Conversation
samuelvl
reviewed
Oct 21, 2025
| kubeLinterEnabled = pflag.Bool("kube-linter-enabled", false, "Kube linter enabled") | ||
| kubeLinterScanInterval = pflag.Duration("kube-linter-scan-interval", 60*time.Second, "Kube linter scan interval") | ||
| kubeLinterInitDelay = pflag.Duration("kube-linter-init-delay", 60*time.Second, "Kube linter init delay") | ||
| // Kubelinter flags are no longer used. Keeping here for now in case some of these flags are still in helm. |
Contributor
There was a problem hiding this comment.
Can't we delete these? I think they would be ignored if defined in helm as well
samuelvl
approved these changes
Oct 21, 2025
Contributor
|
Can we remove this Lines 439 to 440 in 40edc27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.