Skip to content

3.11 - Skip tests that rely on outside resources #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewhilton wants to merge 2 commits into
base: MOODLE_311_STABLE
Choose a base branch
from
Open

3.11 - Skip tests that rely on outside resources #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0b9e24
Skip test based on outside resources
Oct 7, 2018
de7f4c5
Skip test as the video link is not available
Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/filter_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ protected function setUp(): void {
*/
public function test_filter() {
$this->resetAfterTest(true);
// This test is marked as skipped because, writing tests that rely
// on talking to the Internet are a very, very bad idea.
$this->markTestSkipped();

$curl = new curl();
try {
Expand Down
2 changes: 2 additions & 0 deletions tests/oembed_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ public function test_providers() {
* TODO - have a local oembed service with test fixtures for performing test.
*/
public function test_embed_html() {
$this->markTestSkipped("The youtube link is unavailabe");
$this->resetAfterTest(true);
set_config('lazyload', 0, 'filter_oembed');
$this->setAdminUser();
Expand All @@ -107,6 +108,7 @@ public function test_embed_html() {
* TODO - have a local oembed service with test fixtures for performing test.
*/
public function test_preloader_html() {
$this->markTestSkipped("The youtube link is unavailabe");
$this->resetAfterTest(true);
set_config('lazyload', 1, 'filter_oembed');
$this->setAdminUser();
Expand Down