Open
Conversation
added 4 commits
April 1, 2019 15:07
…or a future enddate
We have SQL that will return us a valid queue item, and we don't
need to iterate through to validate queue items before crawling
them.
… the queue
We add all the recent courses once the crawler starts a new
cycle, this is the appropriate place to add all the seed URL's
of each new course we want to start crawling.
- We make a check before parsing the html to check if this is a recent course, so we don't need to have a different queue query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another option of limiting the scope of the crawler, which will allow it to be more focused on courses that are active. This only crawls courses that have an enddate in the future if enabled, and adds the options to only crawl courses that have a certain block enabled. This way we don't crawl unnecessary pages of which there could be many on a big site.