Conversation
david-build
commented
Apr 11, 2023
- Added = sign for base64 url encoding
- Shorter crc16 with same result.
1. Added = sign for base64 url encoding 2. Shorter crc16 with same result.
|
Thanks for the PR. I’ll look into your crc16 implementation, but I cannot understand what’s your idea behind the padding sign replacement ( Could you please elaborate? |
|
Hi, dear! About sign equals: While I wrote the packing and checking CRC16 function for converting RAW to Human Friendly TON address, I did tests on thousands of addresses. And I met somewhere that after base64encode the address got "=" at the end. Therefore, I decided to replace = in my code as well. I think, just in case, it is better to have it than not. Since it has no effect for the worse. |
|
Unfortunately it doesn't work this way. The RFC standard for base64url defines If we replace Also TON addresses are specifically designed not to have |
|
Good, thanks! I'm change it too in our side. |