Syntactical and Guard Fix for Rewrite Rules#24
Open
NeuralCoder3 wants to merge 3 commits intocaviar-trs:mainfrom
Open
Syntactical and Guard Fix for Rewrite Rules#24NeuralCoder3 wants to merge 3 commits intocaviar-trs:mainfrom
NeuralCoder3 wants to merge 3 commits intocaviar-trs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One rule (
lt-mul-pos-cancel) contains a superfluous closing parenthesis.Four other rules (
add-denom-mul,add-denom-div,mul-cancel-div, anddiv-cancel-mul) are missing guards against division-by-zero cases.As other similar rules like
div-cancelcontain these guards, it seems unintended to have these four rules unguarded.