Skip to content

Deisotoping #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Acedon95 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Deisotoping #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65eed16
Test Commit
Mar 31, 2021
2b91fdd
Delete test.txt
Acedon95 Mar 31, 2021
c7c6473
[FIX] Fixed the missing delete in Tutorial_GUI_ParamEditor.cpp and Tu…
Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/code_examples/Tutorial_GUI_ParamEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@ Int main(int argc, const char** argv)

editor->store();
paramFile.store("Tutorial_ParamEditor_out.ini", param);

delete editor;
Copy link
Owner

@cbielow cbielow Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

But:
what happens if an exception is thrown between lines 54 and 60?

-->
better solution (since there is no need for the heap allocation in the first place):

  ParamEditor editor(nullptr);
  editor.load(param);
  editor.show();
  app.exec();

  editor.store();
  paramFile.store("Tutorial_ParamEditor_out.ini", param);

return 0;
} //end of main
2 changes: 1 addition & 1 deletion doc/code_examples/Tutorial_GUI_Plot1D.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ Int main(int argc, const char ** argv)
Plot1DWidget * widget = new Plot1DWidget(Param(), nullptr);
widget->canvas()->addLayer(exp_sptr, on_disc_exp_sptr);
widget->show();

delete widget;
return app.exec();
} //end of main