Replace spin locks with mutex to avoid large atomic context #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes scheduling while atomic caused by called kernel functions create mutexes inside the spin locked section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scheduling while atomic caused by called kernel functions create mutexes inside the spin locked section.
Use mutexes instead of spin locks to protect sysfs callbacks preventing large atomic sections. Otherweis kmalloc with GFP_KERNEL and other kernel functions might sleep and stall the system.
On Ubuntu 24.04 this bug causes segfault of the user processes with
BUG: scheduling while atomicmessages reported in dmesg. In this case specifically a down_write() call sleped when system was under load.