Skip to content

Solves avoid saving base64 images in the db on createBoard()#428

Open
magush27 wants to merge 2 commits intocboard-org:masterfrom
magush27:fix-base64-on-board-creation
Open

Solves avoid saving base64 images in the db on createBoard()#428
magush27 wants to merge 2 commits intocboard-org:masterfrom
magush27:fix-base64-on-board-creation

Conversation

@magush27
Copy link
Copy Markdown
Collaborator

This pull request refactors how base64 images in board tiles are processed during board creation and update, focusing on simplifying function signatures and improving error handling. The changes ensure that the processBase64Images utility no longer requires a boardId, and related logging has been removed for cleaner code. Additionally, the board creation response now includes an isLocalUpdateNeeded flag to signal if local updates are required due to image processing.

Board creation and update improvements:

  • The createBoard function is now asynchronous and processes base64 images in tiles before saving the board. It sets an isLocalUpdateNeeded flag if any images were processed and includes this flag in the response.
  • The updateBoard function now calls processBase64Images without passing a boardId, simplifying the update logic.

Image processing utility refactor:

  • The processBase64Images function in imageProcessor.js no longer requires or uses a boardId parameter, and its documentation has been updated accordingly.
  • Logging of processing statistics via the removed logProcessingStats function has been eliminated for a cleaner codebase.

Closes #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid base64 images on board creation

1 participant