Tried to add-in an option to have multiple locales under one domain...#8
Open
micschk wants to merge 1 commit intocbryer:masterfrom
Open
Tried to add-in an option to have multiple locales under one domain...#8micschk wants to merge 1 commit intocbryer:masterfrom
micschk wants to merge 1 commit intocbryer:masterfrom
Conversation
…and only force a specific domain on some locales (so remove 1:1 chain). Got as far as redirecting to the right locale if in TLD array, but cannot seem to find a way to switch back to default domain for any of the 'unset' locales...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and only force a specific domain on some locales (so remove 1:1 chain). Got as far as redirecting to the right locale only if set in TLD array, but cannot seem to find a way to switch back to default domain for any of the 'unset' locales... (INCOMPLETE SOLUTION)