Optimize for speed #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major performance improvements: - Base32 Decode: Removed UTF8.GetBytes allocation by working directly with string chars - IsValidPrefix: Replaced char.IsLower with direct ASCII range checks (a-z) - IsValidSuffix: Replaced char.IsLetterOrDigit with fast range checks - Parse: Replaced Split with IndexOf to avoid array allocation - GuidToUuid/SuffixToGuid: Use Span<byte> with in-place byte swapping instead of Array.Copy - GetGuid: Use stackalloc and tuple swaps for zero-allocation byte reversal - Base32.Encode: Implement unsafe EncodeCore with fixed pointers to avoid allocations - NewTypeId/Constructor: Use TryWriteBytes with stackalloc instead of ToByteArray - ToString: Use string interpolation instead of concatenation - Enable unsafe code blocks in project files for maximum performance All optimizations maintain correctness while significantly reducing memory allocations and improving execution speed for TypeID generation and parsing operations.
Implemented three automated workflows for continuous integration and testing: 1. Main CI Pipeline (ci.yml): - Multi-version .NET testing (6.0.x, 8.0.x) - Build verification in Debug and Release modes - Comprehensive test execution - Code formatting validation - NuGet package creation - Artifact uploading 2. Performance Testing (performance.yml): - Dedicated performance benchmarks - Target: <0.003ms per TypeID generation - Scheduled weekly runs (Mondays 9 AM UTC) - Detailed performance metrics reporting - Encode/decode performance validation 3. Pull Request Validation (pr-validation.yml): - Automated PR testing - Spec compliance validation - Code coverage reporting - API compatibility checks - Non-draft PR filtering Additional improvements: - Added workflow documentation in .github/workflows/README.md - Updated main README.md with CI status badges - Configured triggers for main/master/develop branches - Added manual workflow dispatch options - Comprehensive test output in GitHub Actions summaries All workflows follow best practices with proper error handling, detailed reporting, and efficient resource usage.
Critical fixes: 1. CI Workflow (.github/workflows/ci.yml): - Separated library build (multi-version) from tests (.NET 8.0 only) - Build library on both .NET 6.0.x and 8.0.x for compatibility - Run tests only on .NET 8.0 (matches test project target) - Updated job dependencies and status checks 2. Base32 Encoding (TypeId/Base32JetPack.cs): - Removed unsafe pointer code that could cause invalid memory access - Replaced unsafe EncodeCore with safe stackalloc implementation - Span<byte> overload now uses direct encoding to stackalloc'd chars - Byte array overload uses string.Create for zero-allocation - All encoding paths remain highly optimized and allocation-free 3. Project Configuration: - Removed AllowUnsafeBlocks from both .csproj files - Code is now safer and more maintainable without unsafe blocks These fixes resolve: - Test failures on .NET 6.0 (tests require .NET 8.0) - Potential memory safety issues with unsafe pointer passing - Build errors related to unsafe code All optimizations maintained while improving code safety and reliability.
Critical fixes: 1. Validation Job (ci.yml): - Added restore dependencies step before building - Added build step before packing NuGet package - Changed pack command to use --no-build flag - Fixes error: DLL not found when packing The validation job now properly: - Restores dependencies - Builds the library in Release configuration - Packs the NuGet package from the built DLL - Uploads artifacts correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.