Upgrade to TypeID Specification (Version 0.3.0) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes:
- Updated prefix validation to allow underscores within prefixes
- Prefixes can now contain underscores in the middle
- Prefixes must still start and end with lowercase letters
- Follows regex: ^([a-z]([a-z_]{0,61}[a-z])?)?$
- Improved suffix validation to properly reject invalid base32 characters (i, l, o, u)
- Updated spec test files (valid.yml and invalid.yml) to version 0.3.0
- Added valid test case: pre_fix_00000000000000000000000000
- Added invalid test cases: _prefix_... and prefix__...
- Updated README.md to reference version 0.3.0
Breaking changes from 0.2.0:
- Prefixes with underscores (e.g., "pre_fix") are now VALID
- Prefixes starting or ending with underscores are now explicitly INVALID
The Parse method was using IndexOf to find the first underscore, which fails when prefixes contain underscores (allowed in 0.3.0 spec). Changed logic to: - Extract the last 26 characters as the suffix - Check that the character before the suffix is the separator underscore - Everything before that separator is the prefix This correctly parses 'pre_fix_00000000000000000000000000' as: prefix: 'pre_fix' suffix: '00000000000000000000000000' Fixes test failure: pre_fix_00000000000000000000000000 should be valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2