Open
Conversation
Collaborator
|
Hi, This is really a great suggestion. Yes the patch will need to be edited for each database accordingly since creating a Hash generates a strict Key for each Gene. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling a system
grepprocess for each line (or two grep processes per line in the case of VEGADB) of the reference databases is inefficient.On my desktop, setup.sh takes almost an hour. Most of this time is in the
check_HGNC_individual_VEGADB.plscript. This patch performs the equivalent in a matter of seconds.The overall setup.sh still takes >20 minutes because something else becomes the rate-limiting step. Something similar could be done for the other
check_HGNC_individual*plscripts, but you would have to be careful because making an index splitting by[\s,]is not the same asgrep -w(for example,hsa-mir-511matcheshsa-mir-511-1when usinggrep -w, but would not match with a simple index of "words" as done here.So this could just be considered an example of how to address an inefficiency in the setup process.