Fix semimonthly socrata upload#1020
Merged
wrridgeway merged 7 commits intomasterfrom Apr 22, 2026
Merged
Conversation
wrridgeway
commented
Apr 22, 2026
Comment on lines
+494
to
+500
| event_type = " ".join( | ||
| filter( | ||
| None, | ||
| [os.getenv("UPLOAD_SCHEDULE"), os.getenv("WORKFLOW_EVENT_NAME")], | ||
| ) | ||
| ) | ||
| print(f"Running upload for event type: {event_type}") |
Member
Author
There was a problem hiding this comment.
Just adding more printing here so it's easier to see what the script is being passed.
jeancochrane
approved these changes
Apr 22, 2026
Member
jeancochrane
left a comment
jeancochrane
left a comment
There was a problem hiding this comment.
Such a devious little bug. Nice catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've reverted some of the changes to
socrata_upload.yaml, but you can see what they were like when I successfully triggered a semimonthly scheduled workflow here (disabled requirement for user to define assets,workflow_dispatchevent returnssemimonthlyforUPLOAD_SCHEDULE).This let me print what was being passed to
UPLOAD_SCHEDULEand it seems like it wassemimonthlybut with a newline at the end. Using a folded block scalar with strip chomping>-forUPLOAD_SCHEDULEsorts this out.You can see a workflow with the unwanted newline in
UPLOAD_SCHEDULEhere.