2024 agency crosswalk vignette#84
Merged
jeancochrane merged 18 commits into2024-data-updatefrom Apr 29, 2026
Merged
Conversation
jeancochrane
requested changes
Apr 22, 2026
Member
There was a problem hiding this comment.
Awesome work here! A couple small nitpicks and only one big thought related to the structure of the agency crosswalk data model. Otherwise, this is looking great.
At some point we should probably have Nicole review this for accuracy, though perhaps we should wait until it's in a closer to finished state? I leave it up to you to decide!
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Member
|
Sorry to steal your thunder @kyrasturgill, but I'm going to merge this now so that I can get a jump on editing it in #89! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to get this up sooner than later so you can start a review if you'd like! I still need to add a bit of narrative at the end of to tie it together. I was debating adding in a section about EAV and new property, but didn't want to stray too far from the original goal of just showing how to use the agency crosswalk. Open to general initial feedback on the structure and content first!