Merged
Conversation
Add enable_mouse_capture()/disable_mouse_capture() methods to Terminal that work at runtime (toggling capture even when raw mode is already active). Change the render loop to accept an optional mouse_capture setting that defaults to enabled for fullscreen and disabled for inline, with an enable_mouse_capture() builder method to opt in for inline mode. Components can now dynamically toggle mouse capture at runtime by calling SystemContext::set_mouse_capture(). The render loop checks this state after each render pass and enables/disables mouse capture on the terminal accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 90.06% 89.00% -1.06%
==========================================
Files 32 33 +1
Lines 5333 5785 +452
Branches 5333 5785 +452
==========================================
+ Hits 4803 5149 +346
- Misses 427 525 +98
- Partials 103 111 +8
🚀 New features to boost your workflow:
|
8a69287 to
975db12
Compare
This was referenced Feb 26, 2026
ccbrown
requested changes
Feb 27, 2026
Owner
ccbrown
left a comment
There was a problem hiding this comment.
This is really well done! 💯
It works great and the API changes look good to me except one minor comment on the ScrollView props.
Otherwise I think this is good to merge.
Thank you!
Add a ScrollView component that provides scrollable content with keyboard (arrows, PageUp/Down, Home/End) and mouse wheel support. Includes auto_scroll mode that pins to bottom using FlexEnd layout, a ScrollViewHandle for imperative control, configurable scroll step, and a visual scrollbar (track + thumb) enabled by default. New scrollbar props: scrollbar (Option<bool>) and scrollbar_color (Option<Color>). Scroll offsets are clamped to valid range. Update the scrolling example to use ScrollView with mouse capture toggle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
975db12 to
238395a
Compare
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71