Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analytics_bottlenecks.pyanalytics_service.get_bottleneck_analyticsas a compatibility wrapper so existing callers and cache monkeypatch tests keep workingVerification
ruff check src/primer/server/services/analytics_service.py src/primer/server/services/analytics_bottlenecks.pyruff format --check src/primer/server/services/analytics_service.py src/primer/server/services/analytics_bottlenecks.pypytest --import-mode=importlib tests/test_analytics.py -qruff check .ruff format --check .bandit -r src/ -c pyproject.tomlpytest --import-mode=importlib -qNote
Medium Risk
Primarily a large refactor that moves complex analytics logic and caching behavior into a new module; risk is moderate due to potential subtle behavioral differences in queries/aggregation and cache wiring despite intended parity.
Overview
Refactors bottleneck analytics by moving friction impact, root-cause clustering, recovery, and time-lost calculations out of
analytics_service.pyinto a newanalytics_bottlenecks.pymodule.analytics_service.get_bottleneck_analyticsis now a thin compatibility wrapper that delegates to the new implementation while still using the existing cache helpers, and the bottleneck-specific constants/helpers are removed from the shared analytics service.Reviewed by Cursor Bugbot for commit ce181bc. Bugbot is set up for automated code reviews on this repo. Configure here.