Skip to content

do not create a new instance of deferred, re-use the existing one. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skojima123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

do not create a new instance of deferred, re-use the existing one. #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions forceng.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,12 +304,14 @@ angular.module('forceng', [])
* params: queryString parameters as a map - Optional
* data: JSON object to send in the request body - Optional
*/
function request(obj) {
function request(obj, deferred) {

var method = obj.method || 'GET',
headers = {},
url = getRequestBaseURL(),
deferred = $q.defer();
url = getRequestBaseURL()
if (deferred === undefined){
var deferred = $q.defer();
}

if (!oauth || (!oauth.access_token && !oauth.refresh_token)) {
deferred.reject('No access token. Login and try again.');
Expand Down Expand Up @@ -346,7 +348,7 @@ angular.module('forceng', [])
refreshToken()
.success(function () {
// Try again with the new token
request(obj);
request(obj, deferred);
})
.error(function () {
console.error(data);
Expand Down