Changed scope of deferred variable in request function.#7
Open
tjmadsen wants to merge 1 commit intoccoenraets:masterfrom
Open
Changed scope of deferred variable in request function.#7tjmadsen wants to merge 1 commit intoccoenraets:masterfrom
tjmadsen wants to merge 1 commit intoccoenraets:masterfrom
Conversation
|
Hi - this causes serious problems for us in our app. Could you please apply this pull-request to fix the issue? Thanks |
|
this causes problems with testing as well. +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #5 where deferred response was being overwritten when responding to simultaneous requests due to the fact that it's scope was broader than the request function.