use SoftFilelock ot ensure model resouce processed correctly#280
Merged
darkrush merged 16 commits intoccprocessor:devfrom Mar 10, 2025
darkrush:filelock
Merged
use SoftFilelock ot ensure model resouce processed correctly#280darkrush merged 16 commits intoccprocessor:devfrom darkrush:filelock
darkrush merged 16 commits intoccprocessor:devfrom
darkrush:filelock
Conversation
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## dev #280 +/- ##
==========================================
- Coverage 90.68% 89.92% -0.76%
==========================================
Files 116 85 -31
Lines 6914 5630 -1284
==========================================
- Hits 6270 5063 -1207
+ Misses 644 567 -77
... and 57 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using SoftFileLock on NFS makes it safe for multiple processes on multiple nodes to handle data resources (download and decompress).
The commonly used resource management interfaces are uniformly exposed in llm_web_kit/model/resource_utils/init.py , so there is no need to call them one by one from each file.
Test on Spark4 with 1000 partition: