Skip to content

fix: simplify test cases by directly setting CACHE_TMP_DIR mock value #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darkrush merged 1 commit into from
Mar 13, 2025
Merged

fix: simplify test cases by directly setting CACHE_TMP_DIR mock value #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tests/llm_web_kit/model/resource_utils/test_download_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,9 @@ def test_s3_connection(self, mock_client):

class TestDownloadCoreFunctionality(unittest.TestCase):

@patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR')
@patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR', '/tmp')
@patch('llm_web_kit.model.resource_utils.download_assets.S3Connection')
def test_successful_download(self, mock_conn, mock_cache_tmp_dir):
mock_cache_tmp_dir.return_value = '/tmp'
def test_successful_download(self, mock_conn):
# Mock connection
download_data = b'data'
mock_instance = MagicMock()
Expand All @@ -83,10 +82,9 @@ def test_successful_download(self, mock_conn, mock_cache_tmp_dir):
assert result == target
assert os.path.exists(target)

@patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR')
@patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR', '/tmp')
@patch('llm_web_kit.model.resource_utils.download_assets.HttpConnection')
def test_size_mismatch(self, mock_conn, mock_cache_tmp_dir):
mock_cache_tmp_dir.return_value = '/tmp'
def test_size_mismatch(self, mock_conn):
download_data = b'data'
mock_instance = MagicMock()
mock_instance.read_stream.return_value = [download_data]
Expand Down