Skip to content

[feat] support math extract from mathjax config #303

Merged
yogacc33 merged 9 commits intoccprocessor:devfrom
e06084:dev
Mar 19, 2025
Merged

[feat] support math extract from mathjax config #303
yogacc33 merged 9 commits intoccprocessor:devfrom
e06084:dev

Conversation

@e06084
Copy link
Copy Markdown
Collaborator

@e06084 e06084 commented Mar 13, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

功能介绍:

  1. 新增BaseMathRender基础渲染器类,及Mathjax类和Katex类,支持基础获取对应配置,find_math等功能;
  2. 目前只有匹配到有定制化的mathjax配置(比如[tex] [/tex])才会走新的逻辑;

测试情况:

  1. 新增了覆盖用例math_physicsforums_1.html,在集成测试bench数据集上测试符合预期;
  2. 另采样2000条左右富集数学公式的测试数据,无异常;
  3. 性能测试:本地kernprof -l -v pytest -s -v tests/st执行19s->20s;

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 89.58333% with 40 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...xtractor/html/recognizer/cc_math/render/mathjax.py 89.58% 20 Missing ⚠️
...extractor/html/recognizer/cc_math/render/render.py 88.88% 10 Missing ⚠️
.../extractor/html/recognizer/cc_math/render/katex.py 93.65% 4 Missing ⚠️
llm_web_kit/exception/exception.py 40.00% 3 Missing ⚠️
llm_web_kit/extractor/html/recognizer/ccmath.py 92.30% 2 Missing ⚠️
llm_web_kit/dataio/filebase.py 87.50% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #303      +/-   ##
==========================================
- Coverage   89.96%   89.90%   -0.07%     
==========================================
  Files          82       89       +7     
  Lines        5581     6051     +470     
==========================================
+ Hits         5021     5440     +419     
- Misses        560      611      +51     
Files with missing lines Coverage Δ
...eb_kit/extractor/html/recognizer/cc_math/common.py 89.87% <ø> (-0.20%) ⬇️
llm_web_kit/dataio/filebase.py 96.96% <87.50%> (ø)
llm_web_kit/extractor/html/recognizer/ccmath.py 88.88% <92.30%> (+2.52%) ⬆️
llm_web_kit/exception/exception.py 98.53% <40.00%> (-1.47%) ⬇️
.../extractor/html/recognizer/cc_math/render/katex.py 93.65% <93.65%> (ø)
...extractor/html/recognizer/cc_math/render/render.py 88.88% <88.88%> (ø)
...xtractor/html/recognizer/cc_math/render/mathjax.py 89.58% <89.58%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@e06084 e06084 force-pushed the dev branch 4 times, most recently from 41c7387 to 68267c2 Compare March 16, 2025 14:45
Comment thread test_math.py Outdated
Comment thread llm_web_kit/extractor/html/recognizer/cc_math/render/katex.py Outdated
@yogacc33 yogacc33 merged commit 9200551 into ccprocessor:dev Mar 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants