Skip to content

perf: optimize math#306

Closed
e06084 wants to merge 1 commit intoccprocessor:devfrom
e06084:perf
Closed

perf: optimize math#306
e06084 wants to merge 1 commit intoccprocessor:devfrom
e06084:perf

Conversation

@e06084
Copy link
Copy Markdown
Collaborator

@e06084 e06084 commented Mar 17, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  1. 优化math模块的抽取性能, display公式的匹配正则做了优化,增加通配符\begin{.*?}的匹配,单机本地1条html测试性能:11.5ms -> 7.5ms;

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #306      +/-   ##
==========================================
+ Coverage   89.70%   89.92%   +0.22%     
==========================================
  Files          82       82              
  Lines        5556     5570      +14     
==========================================
+ Hits         4984     5009      +25     
+ Misses        572      561      -11     
Files with missing lines Coverage Δ
...eb_kit/extractor/html/recognizer/cc_math/common.py 90.07% <ø> (+0.91%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drunkpig drunkpig closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants