One likely fix, 2 cosmetic fixes, udev-rules-file#38
Open
avl42 wants to merge 1 commit intoccwienk:masterfrom
Open
One likely fix, 2 cosmetic fixes, udev-rules-file#38avl42 wants to merge 1 commit intoccwienk:masterfrom
avl42 wants to merge 1 commit intoccwienk:masterfrom
Conversation
ccwienk
approved these changes
Jan 31, 2025
Author
|
that's strange... github adds a warning about a conflict. But this conflict seems bizarre. This is what I thought it SHOULD look like: This so-called conflict appears to have multiple instances of the "Temp-Outer" re.search-line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
"etc--udev--rules.d--24-TEMPer.rules"
This file can be copied to /etc/udev/rules.d/24-TEMPer.rules, then any of the
supported thermometers will have their device-entries (
hidraw*ortty*)be read- and writeable by all users of group "plugdev" - allowing to use
temper.py without sudo.
In temper.py there is one change in a regular expression.
A couple lines down from that there was a "recent" change in
a similar regular expression, and it makes sense for me, that
the two regular expressions should be structurally equal.
But then again, I do not own one of these devices, so I cannot
test them myself.
The removed semicolons ";" are purely cosmetic, and so is
the one change in a function's comment.
Take it, leave it, or cherrypick it... :-)