Refactor video frame texture update logic and clean up unused code#1
Refactor video frame texture update logic and clean up unused code#1emanuele-artioli wants to merge 1 commit intocd-athena:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors code formatting and removes unused code in the video uploading component. The changes focus on improving code consistency with the project's style guide (Airbnb) and cleaning up dead code.
Changes:
- Reorganized import statements to group type imports together, consistent with the pattern in SampleLayout.tsx
- Reformatted the
updateVideoFrameTexturefunction with proper indentation and quote style - Removed unused parameter from
effectController.onChangecallback
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { texture: videoFrameTexture }, | ||
| [video.videoWidth, video.videoHeight], | ||
| ); | ||
| // } |
There was a problem hiding this comment.
This closing comment brace on line 132 is part of the dead code that should be removed. It corresponds to the commented opening condition on line 102.
| // if (video.videoWidth > 0 && video.videoHeight > 0) { | ||
| // const currentWidth = video.videoWidth; | ||
| // const currentHeight = video.videoHeight; |
There was a problem hiding this comment.
The commented code on lines 102-104 and 132 appears to be unused dead code that should be removed entirely rather than kept as comments. The variables currentWidth and currentHeight are declared but never used, and the outer condition check is redundant with the check on line 106.
2 participants
No description provided.