-
Notifications
You must be signed in to change notification settings - Fork 84
Add try/except/else/finally flowchart support #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5ca4ff1
Initial plan
Copilot b20630a
Add stale issue/PR management GitHub Actions workflow
Copilot 00e535a
Add try/except/else/finally flowchart support (fix issue #18); remove…
Copilot 5f64dbd
Add complex try/except test cases: full clauses, sequence, and loop
Copilot 677feff
docs: document try/except/else/finally as beta feature in README (EN …
Copilot c9163a8
test+docs: pin try-multiline-body behavior and document recommendatio…
Copilot c0a85e8
fix: fold multi-statement try body into single node for correct excep…
Copilot d4d0ffc
Bump version to v0.6.0b1
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot join the lines manually? would it work properly with complex cases? for example, nested condition or loop statements. is this an existing pattern used in the existing code? it's ok to use it if it's an existing pattern or else it should be introduced more carefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
astunparse.unparse(stmt)handles complex statements correctly — it's a complete AST→source serialiser and produces valid multi-line output for nestedif,for,while, etc. (tested above with both a nestedifand aforloop inside the try body).This is already the established pattern in the codebase:
CommonOperation.__init__does exactlyOperationNode.__init__(self, operation=self.ast_to_source())which isastunparse.unparse(self.ast_object).strip(), and it's the fallback used for any unrecognised statement including complex ones. The new code is just doing the same thing per-statement in the try body and joining the results — no new pattern is introduced.