fix: suppress empty response warnings when finish reason is present#347
Closed
chrisnestrud wants to merge 5 commits intocecli-dev:v0.95.9from
Closed
fix: suppress empty response warnings when finish reason is present#347chrisnestrud wants to merge 5 commits intocecli-dev:v0.95.9from
chrisnestrud wants to merge 5 commits intocecli-dev:v0.95.9from
Conversation
Co-authored-by: aider-ce (synthetic/hf:MiniMaxAI/MiniMax-M2)
Collaborator
|
Can we extract these/perform this operation in side of the |
dwash96
reviewed
Jan 3, 2026
| try: | ||
| asyncio.get_running_loop() | ||
| except RuntimeError: | ||
| return _run_sync() |
Collaborator
There was a problem hiding this comment.
I feel like this breaks the spirit of testing a code base by intentionally switching the behavior to accommodate the fact that the tests are not initializing a real environment
dwash96
reviewed
Jan 3, 2026
| self.consolidate_chunks() | ||
| response, _, _, response_meta = self.consolidate_chunks() | ||
|
|
||
| completion_choice = None |
Collaborator
There was a problem hiding this comment.
This is duplicated, because response_meta already contains all of this right?
Move the empty-response detection out of the streaming code paths and into consolidate_chunks metadata so both synchronous and streaming sends share the same finish_reason/content/tool-call bookkeeping. Also drop the sync-only show_send_output_stream wrapper so we no longer change runtime behavior for tests.
Collaborator
|
Addressing this in 0.96.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.