Improve Filter Dialog (especially) on Mobile#248
Improve Filter Dialog (especially) on Mobile#248michikrug wants to merge 2 commits intocecpk:masterfrom
Conversation
|
Question 1: shall I only enable this feature on mobile browsers as it seems to be not a problem on desktop? Question 2: do you think it's worth looking for a possible solution to the broken search? |
|
Thank you for your PR.
Having better performance should be on every device, we don't know if our users are using potatoes computers on par with a mobile device.
I believe that would be mandatory, since the search is really useful. The search would require a refactor to make both those features work together. Maybe rebuilding the filter list after a search could solve this. But this might slow down the search, and this new feature might have been for nothing. 🤔 |
|
Thank you for your input. I will see if I can find any solution to the search.... |
c38611a to
fda52d1
Compare
Description
This PR improves the responsiveness of the filter modal on mobile browsers by only partially displaying mons in chunks of 100. The user can load the next chunks by pressing the new "Load More..." button.
Furthermore, I have changed the former approach of using the
IntersectionObserverto plain lazy loading of images.Hint: Unfortunately, this partially breaks the search functionality as only displayed items are searchable.
Motivation and Context
Currently, the huge amount of >800 mons and the corresponding amount of html nodes freezes mobile browsers when the filter dialog is opened.
How Has This Been Tested?
Own instance on desktop (OSX) and mobile (Android) Chrome.
Screenshots (if appropriate):
Types of changes
Checklist: