Add raw {id} placeholder support for custom art URLs#410
Open
IbbyLabs wants to merge 1 commit intocedya77:devfrom
Open
Add raw {id} placeholder support for custom art URLs#410IbbyLabs wants to merge 1 commit intocedya77:devfrom
IbbyLabs wants to merge 1 commit intocedya77:devfrom
Conversation
Preserve the original meta.id during custom art ID extraction and expose it to custom art URL resolution as a new {id} placeholder.
Document the new placeholder in the configurator helper text and add a focused regression test for raw id extraction and pattern substitution.
Author
|
@cedya77 please take a look at this when you get a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{id}placeholder support for custom art URL patternsmeta.idduring custom art ID extraction{id}in the configurator helper textWhy
XRDB and similar integrations sometimes need the original source id, such as
mal:16498, when building custom poster URLs. AIOMetadata already exposes provider specific placeholders like{mal_id}and{tmdb_id}, but without a raw{id}placeholder mixed content integrations have to choose between provider specific fallbacks that do not cover every item cleanly.This change is additive only and keeps all existing placeholders unchanged.
Root Cause
Custom art URL resolution only replaced provider specific placeholders and did not preserve the raw
meta.idas a resolvable value. That blocked integrations that need the original source id for cases like MAL anime search and catalog items.Validation
node --test addon/tests/custom-art-id-placeholder.test.jsnpx eslint addon/index.js addon/utils/parseProps.js configure/src/components/sections/ArtProviderSettings.tsx addon/tests/custom-art-id-placeholder.test.js