Skip to content

Use string matching instead of errors.Is #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dominator008 merged 1 commit into from
Nov 20, 2025
Merged

Use string matching instead of errors.Is #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions eth/transactor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ func (t *Transactor) transact(
signer.Nonce = nonceInt
tx, err := method(client, signer)
if err != nil {
if errors.Is(err, core.ErrNonceTooLow) || errors.Is(err, txpool.ErrReplaceUnderpriced) { // retryable nonce errors
errStr := err.Error()
if strings.Contains(errStr, core.ErrNonceTooLow.Error()) || strings.Contains(errStr, txpool.ErrReplaceUnderpriced.Error()) { // retryable nonce errors
if !(txopts.noNonceRetry && txopts.nonce != 0) { // retry allowed (either flag not set or nonce not explicitly provided)
nonce++
log.Debugf("TxMethod nonce err: %s, retrying with nonce %d", err, nonce)
Expand Down Expand Up @@ -231,7 +232,7 @@ func (t *Transactor) waitTxAsync(
if handler.OnError != nil {
handler.OnError(tx, err)
}
if errors.Is(err, ethereum.NotFound) && pendingNonce > 0 {
if strings.Contains(err.Error(), ethereum.NotFound.Error()) && pendingNonce > 0 {
// reset transactor nonce to pending nonce
// this means pending txs after this will probably fail
t.lock.Lock()
Expand Down
Loading