client: submitpfb partial response support#59
Open
walldiss wants to merge 5 commits intocelestiaorg:mainfrom
Open
client: submitpfb partial response support#59walldiss wants to merge 5 commits intocelestiaorg:mainfrom
walldiss wants to merge 5 commits intocelestiaorg:mainfrom
Conversation
walldiss
force-pushed
the
submitpfb_partial_resonse_support
branch
from
30197bc to
1913919
Compare
walldiss
changed the title
walldiss
changed the title
walldiss
force-pushed
the
submitpfb_partial_resonse_support
branch
3 times, most recently
from
9532396 to
b87ae04
Compare
walldiss
force-pushed
the
submitpfb_partial_resonse_support
branch
from
b87ae04 to
64c58de
Compare
walldiss
force-pushed
the
submitpfb_partial_resonse_support
branch
from
447a228 to
3248676
Compare
Member
Author
|
@omritoptix This error handling is a bit tricky. First error here is networking client error, and if it happens, there will be no response value returned. The second error here is constructed inside client, when http code is >500. For partial responses in node we use code 206, so if code 500 is returned, there were no txresp to return. I did a simplification of this PR, so hopefully it will get merged soon. |
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 37.14% 35.48% -1.66%
==========================================
Files 3 4 +1
Lines 175 186 +11
==========================================
+ Hits 65 66 +1
- Misses 97 106 +9
- Partials 13 14 +1
|
Wondertan
reviewed
Jun 13, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/celestiaorg/go-cnc | |||
|
|
|||
| go 1.19 | |||
Member
There was a problem hiding this comment.
If we want to update the version, we should be doing it in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #58