Update datatypes to be compatible with numpy >= 1.20#14
Open
fnands wants to merge 4 commits intocentreborelli:masterfrom
Open
Update datatypes to be compatible with numpy >= 1.20#14fnands wants to merge 4 commits intocentreborelli:masterfrom
fnands wants to merge 4 commits intocentreborelli:masterfrom
Conversation
Change `np.float` to `np.float32`
Change `np.bool` to `bool`
Change `np.int` to `np.int32`
Change `np.int` to `np.int32`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datatypes
np.bool,np.floatandnp.inthave been deprecated since numpy 1.20.This means running the code with a newer version will result in a crash.
This PR updates the datatypes.
The recommended updates for
np.floatandnp.intare the native datatypesintandfloat, but as there were other occasions in the code wherenp.float32andnp.int32were used, I updated them to these for the sake of consistency.