Conversation
lemunozm
force-pushed
the
migration-v3.1-cleaning
branch
from
7f3d869 to
367dd62
Compare
onnovisser
approved these changes
Feb 5, 2026
wischli
approved these changes
Feb 5, 2026
| import {PoolId} from "../../src/core/types/PoolId.sol"; | ||
| import {AssetId} from "../../src/core/types/AssetId.sol"; | ||
|
|
||
| import {Root} from "../../src/admin/Root.sol"; |
Contributor
There was a problem hiding this comment.
What's the reason for keeping this file around despite removing the other ones?
Contributor
Author
There was a problem hiding this comment.
Good question! I thought it could be interesting to still have some mechanism to fetch from the indexer, but it's true the current one is tied to the migration. Would be really cool to tell claude to have a whole graphQL parser of the current state 🤔
By now probably we can probably remove, yes. I'll do in a follow-up PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product requirements
Root. This is important to remove, because it was core specific for the migration v3.1. If we do some error deploying usingROOTenvvar, we will deploy unaccessible contracts, forcing us to redeploy with a different create3 for that address.From this, I have some ideas to generalize the validation system to support any kind of spell/migration in a generic way (WIP). By now, we can remove these no longer used files.