Fixes for post_processing code for the total_iodepth feature #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 7, 2025 16:34
Signed-off-by: Chris Harris (harriscr@uk.ibm.com)
Signed-off-by: Chris Harris (harriscr@uk.ibm.com)
Signed-off-by: Chris Harris (harriscr@uk.ibm.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the inclusion of the total_iodepth feature in PR324 the post_processing modules now give eratic results.
This is because currently the code uses the iodepth value from the fio logs, and not the total_iodepth value set as that is never passed to fio.
The temporary fix is to parse the total_iodepth number from the file path used for the fio results run via CBT (taken from the write_iops_log value stored in the fio output file.
A better fix can be done when the workloads code is split into its own module, and we can write the total_iodepth value somewhere that the post_processing code can read, or we have a better way to cnnect the fio results to the workload that ran it. Until then, this code will allow the post processing to work with the total_iodepth feature