Skip to content

Conversation

@jharbott
Copy link

This is a clean cherry-pick from upstream master. Partial fix for http://tracker.ceph.com/issues/19917

@jharbott
Copy link
Author

Hmm, I just gave this a test run and it seems to include the header size in the count, which is a bit unexpected when compared to the data one would usually see in other webserver's logs. Doing e.g. a GET of an object of 4 bytes size will show about 450 bytes being sent, the exact number depending on the metadata of the object. While this is not wrong in itself, I'm still wondering whether this is the solution we want or whether we want the pure content size to be logged, matching what the Content-Length header says.

@theanalyst
Copy link
Member

yeah that would be confusing

@yaozongyou
Copy link

Hi, is there any plan to merge this pr? Currently, the num_bytes_sent in civetweb's access log is always zero. We would better to merge this.

@theanalyst
Copy link
Member

so this will log total bytes sent in to the client, which I guess is acceptable from a webserver's pov

Copy link

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a reference, the bytes_transferred value in Apache trnasfer logs includes headers
http://httpd.apache.org/docs/current/mod/mod_log_config.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants