Add headers for SoA generation#52
Merged
sbaldu merged 1 commit intocern-nextgen:mainfrom Dec 19, 2025
Merged
Conversation
leobeltra
force-pushed
the
feature/soa-generation-template
branch
from
316b94f to
a449a64
Compare
sbaldu
reviewed
Dec 19, 2025
tests/soa_template/CMakeLists.txt
Outdated
Comment on lines
+4
to
+13
| include(CheckLanguage) | ||
| check_language(CUDA) | ||
| if(CMAKE_CUDA_COMPILER) | ||
| add_subdirectory(cuda) | ||
| endif() | ||
|
|
||
| check_language(HIP) | ||
| if(CMAKE_HIP_COMPILER) | ||
| add_subdirectory(hip) | ||
| endif() |
Collaborator
There was a problem hiding this comment.
So far you only add cpu tests, so this will fail to configure. Comment these lines for now please.
sbaldu
reviewed
Dec 19, 2025
| @@ -0,0 +1,15 @@ | |||
| find_package(Boost 1.75 REQUIRED) | |||
Collaborator
There was a problem hiding this comment.
This should be in the base CMake file of soa_template.
sbaldu
reviewed
Dec 19, 2025
|
|
||
| target_include_directories(soa_template_cpu.out PRIVATE | ||
| ${CMAKE_SOURCE_DIR}/../include | ||
| ${doctest_SOURCE_DIR}/doctest |
Collaborator
There was a problem hiding this comment.
These libraries should be included with target_link_libraries(target PRIVATE Boost::boost doctest::doctest)
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
leobeltra
force-pushed
the
feature/soa-generation-template
branch
from
e7e6e87 to
6d4023a
Compare
sbaldu
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the SoA generator feature to xstl.
TODOs: