Fixed CA identifier to not sent non-existing issuer identifier if not set explicitly#190
Open
kyberpunk wants to merge 1 commit intocertnanny:masterfrom
Open
Fixed CA identifier to not sent non-existing issuer identifier if not set explicitly#190kyberpunk wants to merge 1 commit intocertnanny:masterfrom
kyberpunk wants to merge 1 commit intocertnanny:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR is supposed to fix issue #160. If -i flag is not set in sscep GetCACert or GetNextCACert command, it always sends "message=CAIdentifier" query parameter which is not expected and does not represent any existing CA alias. This parameter is not supported by original RFC 8894 and was added in https://datatracker.ietf.org/doc/html/draft-nourse-scep-23.
From RFC https://datatracker.ietf.org/doc/html/draft-nourse-scep-23:
The MESSAGE MAY be omitted, or it MAY be a string that represents the
certification authority issuer identifier. A CA Administrator
defined string allows for multiple CAs supported by one SCEP server.
SCEP servers which implement draft-nourse-scep-23 will always return 404 because they cannot find any CA with senseless name "CAIdentifier" even you define the default CA.
This issue causes that many routers (e.g. Garderos, Teltonika, ...) cannot be enrolled with Keyfactor EJBCA and other CA implementations which follows draft-nourse-scep-23 SCEP version, because they don't explicitly set this paramter.