Open
Conversation
cesc1802
reviewed
Aug 24, 2021
| "github.com/jinzhu/gorm" | ||
| ) | ||
|
|
||
| func GetDB() *gorm.DB { |
Owner
There was a problem hiding this comment.
Sau khi khởi tạo connect đến cơ sở dữ liệu, thì mình nên lưu lại cái connect đó để tái sử dụng. Không nên mỗi lần có request từ client thì tạo một connect mới
cesc1802
reviewed
Aug 24, 2021
| // return resp | ||
| //} | ||
|
|
||
| GetDB().Create(task) |
Owner
There was a problem hiding this comment.
Mỗi lần GetDB() được gọi sẽ khởi tạo một connection mới tới db, nên rất tốn tài nguyên. Cần lưu ý cách sử dụng này
cesc1802
reviewed
Aug 24, 2021
| } | ||
|
|
||
| //contact.UserId = user | ||
| resp := task.Create() |
Owner
There was a problem hiding this comment.
ở chỗ này chưa có kiểm tra lỗi khi không tạo được task
cesc1802
reviewed
Aug 24, 2021
| } | ||
|
|
||
|
|
||
| func GetTasks() ([]*Task) { |
Owner
There was a problem hiding this comment.
theo convention chuẩn của Go, thì 1 function nên trả về kết quả và error. Ví dụ func GetTasks() ([]*Task, error)
| test string `json:"test"` | ||
| } | ||
|
|
||
| func GetUsers() ([]*Users) { |
Owner
There was a problem hiding this comment.
chỗ này cũng tương tự, nên trả về kết quả và error
cesc1802
approved these changes
Aug 24, 2021
Owner
|
Những chức năng còn thiếu:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.