Check element size when parsing tokens #425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… length never exceeds DB_MAX_ELEMENT_SIZE - 1 before copying into lexer->value. This prevents potential buffer overflows when parsing long strings or identifiers and guarantees that the token value is always null-terminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Development Team,
This PR addresses a potential buffer overflow in the lexer’s token parsing
logic. The computed token length was not checked against
DB_MAX_ELEMENT_SIZE - 1, which may lead to out-of-bounds writes whenhandling overly long tokens.
This issue corresponds to the vulnerability described in CVE-2018-1000804.
The patch adds the necessary bounds check to ensure safe and
null-terminated token copying.
Please review at your convenience. Thank you!