Conversation
Tests cover: single/multiple result parsing, top_k limiting, empty HTML, whitespace normalization, missing href fallback, mismatched links/snippets zip behavior, and top_k zero edge case. https://claude.ai/code/session_01RCPTr5eo8aMs3NvG5h9YrG
- DuckDuckGoEngine::new() rejects empty/whitespace-only queries - parse_results() rejects top_k of zero - Introduces SearchError enum with EmptyQuery, InvalidTopK, Http variants - Updates main.rs to handle the new Result return types - Adds tests for both validation cases https://claude.ai/code/session_01RCPTr5eo8aMs3NvG5h9YrG
Instead of silently exiting with empty output, prints "no results found for query" to stderr and exits with code 1. https://claude.ai/code/session_01RCPTr5eo8aMs3NvG5h9YrG
Splits InvalidTopK into TopKTooLow (zero) and TopKTooHigh (>100) so users get a clear message for either invalid direction. https://claude.ai/code/session_01RCPTr5eo8aMs3NvG5h9YrG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding unit tests and changing ambiguous responses when passing in bad query parameters