-
Notifications
You must be signed in to change notification settings - Fork 75
Stop docs generation if npm build:all script failed & added codeblock pre-processor #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
@cf-bottom jenkins please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/177/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-177/output/_site/ |
failed build is ok, as it what actually should happen when there is build error (we have one rn). |
@cf-bottom please jenkins. now I added "together https://github.com/NorthernTechHQ/nt-docs/pull/3" that should fix the build issue |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/178/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-178/output/_site/ |
@cf-bottom jenkins pleaz |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/179/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-179/output/_site/ |
083c8f8
to
de95a65
Compare
@cf-bottom jenkins please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/180/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-180/output/_site/ |
@cf-bottom jenkins please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/181/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-181/output/_site/ |
b10cd86
to
e19496b
Compare
@cf-bottom jenkins please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/182/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-182/output/_site/ |
@cf-bottom jenkins please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/184/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-184/output/_site/ |
e19496b
to
4e281bf
Compare
@cf-bottom jenkins please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/186/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-186/output/_site/ |
Otherwise Hugo will fail to parse markdown with error: failed to parse Markdown attributes; you may need to quote the values Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
4e281bf
to
d7d7f7f
Compare
@cf-bottom jenkins please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/188/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-188/output/_site/ |
r"^\s*```([a-zA-Z0-9_-]+)" # language | ||
r"[ \t]+\{([^}]*)\}\s*$", # flags | ||
re.MULTILINE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksandrychev I don't think these can be multiline?
together: https://github.com/NorthernTechHQ/nt-docs/pull/5