Conversation
|
|
@flacoman91 Perhaps you can walk me through the changes tomorrow so that I can better understand them? As a first step can you change the casing of "Link Text" to "Link text" to align with our content style guidelines for links? What is the difference between "Warning" and "Destructive"? Are the styles identical? I only see "Destructive link" in the DS. |
|
For the appearance options, I believe that destructive and warning refer to the same thing. Should we consolidate into one? @anselmbradford - Would it make sense for these to be called "destructive" in the code instead of warning? This would align with the user facing titles for these and would avoid confusion about their use case. For this one, I am hoping that in the near future we can stop referring to this as "Jump" in the code since this is a "Standalone link." Would it be confusing for a React user if we used "IsStandalone" in the DSR use case even if the code continues to call this <a class="a-link a-link--jump" for the time being? @anselmbradford |
Appearance is if it's a link stylized as a button? Looks like warning, primary, secondary from https://cfpb.github.io/design-system/components/buttons#types-1 and then destructive is https://cfpb.github.io/design-system/components/links#destructive-link
"Inline" and "Standalone" are separate here https://cfpb.github.io/design-system/components/links#types-1 |
|
I think that warning as a button appearance may be some old legacy thing. I am in favor of keeping it consistent and calling it I am hoping to keep the pattern consistent because the way links and buttons change their appearance in DSR use either https://github.com/cfpb/design-system-react/blob/main/src/components/Link/link.tsx#L48 |
|
@flacoman91 |


This PR removes the type property from the Link component in favor of the appearance prop to make it like the Button component
It would be simpler to just keep things as appearance for both Button and Link
valid params can now be Warning or Destructive
Changes
How to test this PR
Screenshots
Notes