Conversation
|
contolini
force-pushed
the
eleventy-migration
branch
5 times, most recently
from
f513b85 to
e2e9f89
Compare
|
This looks good locally, but is it expected that the Cypress PR tests fail? |
contolini
force-pushed
the
eleventy-migration
branch
from
c700413 to
ad392a9
Compare
NOPE. I made some more Eleventy changes on the editing interstitial page. Tests should pass now. |
contolini
force-pushed
the
eleventy-migration
branch
3 times, most recently
from
eb0ba82 to
c9d352d
Compare
| with: | ||
| node-version: 22 | ||
|
|
||
| - name: Set up Ruby for Jekyll |
| margin: 2rem 0 1rem; | ||
| } | ||
|
|
||
| /* Pygments via Jekyll */ |
There was a problem hiding this comment.
What is this code comment in reference to? Can the CSS below go?
There was a problem hiding this comment.
Great question. No idea. Everything below here is .highlight stuff which AFAIK is for code snippets. I'm too scared to touch it in this PR.
|
On the PR preview, any idea what's going on with the icon here? Jekyll: Eleventy: |
I don't know why, but there's a bunch of stray |
|
I also see some inconsistencies between the PR preview and the Jekyll site: Icon size is different and some of the rows are of differing size in the PR preview page. I also see some of this {: class="icon-table"} repeated at the end of the tables here: https://cfpb.github.io/design-system/pr-preview/pr-2512/foundation/iconography/ 
Interestingly, pulling the branch and building looks the same as the live site (for the above images). |
|
FWIW I did a quick qa pass of the website. Different issue, or maybe this is to be expected, but the PR preview link now 404s when I visit it. I don't see the pr-preview/ dir on gh-pages. It occured to me that it may be that the whole gh-pages branch may be getting overwritten either by the bulid script or the pr-preview action. Might be something to look into. |
|
I noticed the "last updated" tagline is showing up on pages where it's ignored on the live site:
|
Add GH PR preview action Remove netlify config file Destructure Decap template props so that previews render properly Replace the react-liquid icon injection hack with an esbuild module Preserve the `pr-preview` dir when deploying to GH pages The PR preview was mysteriously disappearing. Turns out that if someone opens or touches an unrelated PR, it'll deploy to GH pages and wipe out the PR previews from other pull requests. So now we use rsync to preserve the `pr-preview` directory. Eleventy uses 'collections.all' instead of 'site.pages' Update lockfile after fixing merge conflict
contolini
force-pushed
the
eleventy-migration
branch
from
c9d352d to
7794ee3
Compare
contolini
force-pushed
the
eleventy-migration
branch
from
7794ee3 to
cbe1eba
Compare
4 participants
Replaces Jekyll with Eleventy (the Node.js-based site generator most similar to Jekyll). Removes all the Ruby requirements from this repo.
Additions
Removals
Testing
yarn && yarn after-install && yarn startand it should look the same as the Jekyll version of the siteNotes
Icon injection needs to be fixed https://cfpb.github.io/design-system/pr-preview/pr-2512/foundation/iconography/This should now work in both the built site and Decap CMS previews.