feat(changelog): move announcements page data into markdown from JSON#2710
Open
feat(changelog): move announcements page data into markdown from JSON#2710
Conversation
33b353f to
9088d9c
Compare
9088d9c to
277d413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes our announcements page more maintainable by storing its content in markdown instead of JSON.
Changes
Testing
yarn && yarn startNotes
useRemoteMarkdown.jsxis a copy ofuseRemoteJSON.jsxwith a few minor changes. Another option would have been to rename the file to something generic likeuseRemoteFile.jsxand do filetype checking in the hook to return either JSON or markdown. Lmk if you'd prefer that method.