Skip to content

feat(changelog): move announcements page data into markdown from JSON#2710

Open
contolini wants to merge 2 commits intomasterfrom
5460-markdown
Open

feat(changelog): move announcements page data into markdown from JSON#2710
contolini wants to merge 2 commits intomasterfrom
5460-markdown

Conversation

@contolini
Copy link
Member

Makes our announcements page more maintainable by storing its content in markdown instead of JSON.

Changes

Testing

  1. Pull down this branch.
  2. yarn && yarn start
  3. Visit http://localhost:3000/updates-notes and everything should look like https://ffiec.cfpb.gov/updates-notes

Notes

  • The markdown changelog was added in a previous PR and already exists in master. We'll delete the JSON version in a future PR once we're sure everything works as expected.
  • useRemoteMarkdown.jsx is a copy of useRemoteJSON.jsx with a few minor changes. Another option would have been to rename the file to something generic like useRemoteFile.jsx and do filetype checking in the hook to return either JSON or markdown. Lmk if you'd prefer that method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant